feat(web): add toggle shortcut for settling threads by UtkarshUsername · Pull Request #7881 · pingdotgg/t3code

UtkarshUsername · 2026-08-22T08:50:29Z

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

^{Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `thread.settle.toggle` shortcut bound to `mod+shift+s` in chat route

Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

^{Macroscope summarized af57392.}

Settling a thread had no keyboard shortcut. Add thread.settle.toggle (command ID thread.settle.toggle) with default mod+shift+s (when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The handler toggles the active thread via effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread. No mobile changes; desktop inherits via web.

coderabbitai · 2026-08-22T08:50:39Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-08-22T09:03:09Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

Sidebar partitions snoozed threads before settled ones, but the toggle only excluded pinned threads. A snoozed thread that also satisfies effectiveSettled was treated as settled and would be unsettle-d instead of settled. Mirror the partition ordering by checking effectiveSnoozed first.

UtkarshUsername · 2026-08-22T09:09:17Z

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

macroscopeapp

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

^{Posted via Macroscope — UI Consistency}

The snoozed/pinned exclusions mirrored the sidebar list partition, but the surfaces the user sees on the open thread (parked-thread banner, header menu) classify with effectiveSettled alone. Classify the same way so the shortcut never disagrees with the visible Un-settle button.

macroscopeapp

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

^{Posted via Macroscope — UI Consistency}

The snapshot map is only written by sidebar v2 rows, so on the legacy sidebar (or before a row mounts) the shortcut classified with no PR while the banner and menu used the live one. Resolve through resolveDisplayedThreadPr over the same vcsEnvironment.status query ChatView uses, so all three surfaces agree.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8c56333. Configure here.}

…l PRs

macroscopeapp

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

^{Posted via Macroscope — UI Consistency}

The pending-status snapshot fallback diverged from the banner and menu (both resolve unconditionally) and could go stale on a failed status query. Match ChatView's resolution exactly; the loading window behaves the same as the surfaces the user already sees.

UtkarshUsername · 2026-08-25T05:44:50Z

#8089

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026

cursor Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

UtkarshUsername marked this pull request as draft August 22, 2026 09:35

UtkarshUsername added 2 commits August 22, 2026 19:54

Merge branch 'main' into feat/thread-settle-toggle-shortcut

311be01

Merge branch 'main' into feat/thread-settle-toggle-shortcut

d999951

UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14

cursor Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx

fix(web): consume repeat events for settle toggle

6f592f7

macroscopeapp Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

macroscopeapp Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026

cursor Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

UtkarshUsername and others added 2 commits August 22, 2026 21:51

fix(web): depend on git status data, not query object

ed7f8e4

Merge branch 'main' into feat/thread-settle-toggle-shortcut

1d52535

cursor Bot reviewed Aug 23, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx

fix(web): keep open PRs visible while VCS status loads

8c56333

macroscopeapp Bot reviewed Aug 23, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

cursor Bot reviewed Aug 23, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

fix(web): tighten pending-status snapshot rule to matching or termina…

c554166

…l PRs

macroscopeapp Bot reviewed Aug 23, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

macroscopeapp Bot reviewed Aug 23, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.tsx Outdated

UtkarshUsername and others added 2 commits August 23, 2026 14:15

Merge branch 'main' into feat/thread-settle-toggle-shortcut

726b52d

UtkarshUsername marked this pull request as draft August 23, 2026 18:21

Merge branch 'main' into feat/thread-settle-toggle-shortcut

518d7c2

UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50

Merge branch 'main' into feat/thread-settle-toggle-shortcut

04a71f6

t3dotgg mentioned this pull request Aug 24, 2026

feat(web): settle and restore threads with a keyboard shortcut #8089

Merged

Merge branch 'main' into feat/thread-settle-toggle-shortcut

af57392

UtkarshUsername closed this Aug 25, 2026

UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45

Uh oh!

Conversation

UtkarshUsername commented Aug 22, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

Video

Checklist

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

Uh oh!

coderabbitai Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

macroscopeapp Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

UtkarshUsername commented Aug 22, 2026

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

UtkarshUsername commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

UtkarshUsername commented Aug 22, 2026 •

edited by cursor Bot

Loading

Add `thread.settle.toggle` shortcut bound to `mod+shift+s` in chat route

coderabbitai Bot commented Aug 22, 2026 •

edited

Loading

macroscopeapp Bot commented Aug 22, 2026 •

edited

Loading